embed-mode: add documentation for new opencloud-embed:share-links event#510
Merged
Svanvith merged 2 commits intoopencloud-eu:mainfrom Nov 28, 2025
Merged
embed-mode: add documentation for new opencloud-embed:share-links event#510Svanvith merged 2 commits intoopencloud-eu:mainfrom
Svanvith merged 2 commits intoopencloud-eu:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for a new owncloud-embed:share-links event that replaces the deprecated opencloud-embed:share event. The new event provides enhanced functionality by including passwords when applicable.
- Introduces documentation for the new
owncloud-embed:share-linksevent with password support - Marks the existing
opencloud-embed:shareevent as deprecated - Adds a complete code example demonstrating how to handle the new event
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dschmidt
force-pushed
the
share-links-event
branch
from
c2095e9 to
103c5c3
Compare
dschmidt
changed the title
Member
|
Please rebase, there are breaking changes on the main branch. |
Contributor
Author
|
No idea what you did ... I just rebased on top of the main branch and now I have 4 commits and 312 changed files in this PR ... |
dschmidt
force-pushed
the
share-links-event
branch
from
b49e128 to
03c83f8
Compare
Contributor
Author
|
Cherrypicked my commit on top of main, looks ok again |
micbar
force-pushed
the
share-links-event
branch
from
59c4b05 to
ea231f7
Compare
micbar
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in opencloud-eu/web#1613 (and name fixed in opencloud-eu/web#1616)
According to @JammingBen this won't be in 4.0.0 - no idea, when the correct time to merge is.